3.3.2 Automated testing

When a merge request is opened, a bot automatically adds the Patch::new label to it, and it enters the countdown cycle. GitLab triggers automated testing, which ensures that the patch completes make, make check, and make doc.

After the CI pipeline has succeeded, the patch meister or any developer (even the author) should check the regression test comparison. When there are no differences, the “Test summary” section of the merge request page has a green check mark. If it instead has a yellow exclamation mark, click the caret to expand the section, then click the “View details” link next to the “Machine review” entry. A window pops up with a link to the regression test visual comparison page.

If tests display no obviously bad differences, the patch can be advanced to Patch::review. If the size of the regression test visual differences allows it, please paste screenshots of them on the merge request page for easier review. Otherwise, simply paste a link to the that page. Also, for changes that are by nature not expected to yield regression test differences, such as documentation improvements, it is not necessary to leave a comment at all. In case any of the testing steps fails, the patch should be set to Patch::needs_work. When revisions are made, this process repeats (if the regression test diff is not changed by the latest iteration, a comment stating so can replace posting screenshots again).